Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all failing tests (13/13 pass) and type errors (
tsc --noEmitclean).environment = "happy-dom"setting with a preload of packages/ui/test/setup.ts (fixesdocument is not defined)useDebouncenow thatuseThrottlehas been renamed1/03/2024)aria-label; icon-only buttons with no label fall back to "Button" and log a console.warnsetSortDir(prev => ...)updater (stale closure)types: ["bun-types"](already a devDependency)Assumptions: no test files changed and no dependencies added. With the DOM loaded, the DataTable tests also pass on the original code, so the updater was kept as the intended fix rather than because the tests needed it. The "Button" fallback is a stopgap and isn't a meaningful accessible name, so callers should still pass a real label. Dates still depend on the machine's timezone, as they did before.